Add option to change thumbnail appearance #3890
Conversation
Makes thumbnail display mode setting also affect thumbnails in ft-list-playlist and playlist-info.
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
There was a problem hiding this comment.
Everything LGTM in testing.
There is only one thing im not sure about and that is how the settings is shown under the distraction free settings.
The distraction free settings are mostly done with toggles to indicate if the feature is off/on. This dropdown could give of the feeling that this setting is always on even though Default is selected.
Maybe we should opt for a toggle to enable this feature and if u enable it u get a dropdown with 2 options blurred or hidden.
Not sure if it can be done better so its best to wait for the members the chime in on this.
Co-authored-by: PikachuEXE <[email protected]>
Head branch was pushed to by a user without write access
|
For making the setting look better (hide behind a toggle) Text & style can be further adjusted
|
|
Just ended up implementing the same solution, not sure if there is a better way. |
Head branch was pushed to by a user without write access
|
Blurred could be converted to a switch and hidden moved into the thumbnail preference drop down (burred can't go in there as you need a thumbnail to blur). |
|
@absidue I'm not opposed to that but im not sure i understand the reasoning for it |
|
I don't even understand that suggestion... |
|
@absidue I don't agree with this approach as the intended purpose of this feature is to minimize distraction and moving it to a different place would make it harder to find for the user. Another concern is that if toggle blur and hidden thumbnails were in a different setting, you would have to run extra checks (wouldn't make sense to blur a hidden thumbnail). (I also think that the thumbnail preference setting is a bit ambiguous right now and maybe should be renamed to something like 'thumbnail position' or 'thumbnail alignment') |
|
What about 2 toggles in the distraction free settings?
If hidden enabled then disable and grey out blur |
|
My reasoning for proposing to move the hidden option to the thumbail preference setting, is that it already has options to use the default thumbail, the first frame in the video, the last frame or one in the middle, so having the hidden/no thumbnail setting in the same dropdown makes a lot of sense to me. Additionally not downloading thumbnails will not only be used as a distraction free setting but also by users that want to save bandwidth or have slow internet connections. |
|
I created a SVG file via https://mediamodifier.com/svg-editor |
Head branch was pushed to by a user without write access
|
@PikachuEXE Good idea! Managed to clean the svg up so now it's ~200 bytes. |
efb4f5ff-1298-471a-8973-3d47447115dc
dismissed
their stale review
see requested changes
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
@da-batt is this ready for review? |
|
@efb4f5ff-1298-471a-8973-3d47447115dc yes, everything should be fine now. |
da-batt
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
removed
the
PR: waiting for review
Add option to change thumbnail appearance
Pull Request Type
Related issue
closes #2814
Description
Added drop-down option to distraction free settings named Thumbnail Display Mode which changes thumbnail behavior depending on selected option. Current options are Hidden (loads a placeholder image instead of thumbnail) and Blurred (blurs thumbnail)
Screenshots
Thumbnail Display Mode - Default
humbnail Display Mode - Hidden
Thumbnail Display Mode - Blurred
Testing
Desktop