Hide recommendations from the Watch component, instead of hiding itself #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Jun 1, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 1, 2024
kommunarr
approved these changes
Jun 1, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 3, 2024
* development: (36 commits) Remove unused database compacting IPC channel (FreeTubeApp#5212) Translated using Weblate (Hungarian) Translated using Weblate (Portuguese) Translated using Weblate (Finnish) Compressed Images (FreeTubeApp#5209) Cleanup unused channel hiding code in ft-list-video-numbered (FreeTubeApp#5208) Translated using Weblate (Serbian) Hide recommendations from the Watch component, instead of hiding itself (FreeTubeApp#5203) Consolidate clear subscriptions cache into one mutation (FreeTubeApp#5202) Translated using Weblate (Spanish) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Polish) Translated using Weblate (Turkish) Translated using Weblate (Hungarian) Translated using Weblate (Croatian) Store comment reply tokens separately to avoid reactivity (FreeTubeApp#5190) Translated using Weblate (Croatian) Translated using Weblate (German) Translated using Weblate (Czech) ... # Conflicts: # src/datastores/handlers/base.js # src/renderer/store/modules/subscriptions.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide recommendations from the Watch component, instead of hiding itself
Pull Request Type
Description
Currently the "Hide Recommended Videos" setting creates the
watch-video-recommendationscomponent with the props, starts rendering the template and then encounters thev-ifthat stops it actually rendering anything onto the page. This pull request instead moves thev-ifinto the parent component (Watch), that way no work is done concerning that component, not even creating the component instance, when the "Hide Recommended Videos" setting is enabled.Testing
Check that the "Hide Recommended Videos" setting still works in both it's on and off state.
Desktop