Switch settings sections and form elements to created lifecycle hook #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Jun 4, 2024
kommunarr
approved these changes
Jun 4, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 4, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 5, 2024
* development: Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (French) Translated using Weblate (Spanish) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Spanish) Make adding duplicate disabled by default (FreeTubeApp#5044) Switch settings sections and form elements to created lifecycle hook (FreeTubeApp#5224) Translated using Weblate (French) Translated using Weblate (Estonian) Bump sass from 1.77.2 to 1.77.4 (FreeTubeApp#5222) Bump lefthook from 1.6.13 to 1.6.15 (FreeTubeApp#5223) Bump the eslint group with 2 updates (FreeTubeApp#5218) Bump electron from 30.0.8 to 30.0.9 (FreeTubeApp#5221) Bump swiper from 11.1.3 to 11.1.4 (FreeTubeApp#5220) Bump stylelint from 16.6.0 to 16.6.1 in the stylelint group (FreeTubeApp#5219) Add missing IPC channel constants (FreeTubeApp#5216)
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 5, 2024
* feature/subscription-cache: ! Rename subscriptions to subscription cache & fix outdated mutation reference Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (French) Translated using Weblate (Spanish) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Spanish) Make adding duplicate disabled by default (FreeTubeApp#5044) Switch settings sections and form elements to created lifecycle hook (FreeTubeApp#5224) Translated using Weblate (French) Translated using Weblate (Estonian) Bump sass from 1.77.2 to 1.77.4 (FreeTubeApp#5222) Bump lefthook from 1.6.13 to 1.6.15 (FreeTubeApp#5223) Bump the eslint group with 2 updates (FreeTubeApp#5218) Bump electron from 30.0.8 to 30.0.9 (FreeTubeApp#5221) Bump swiper from 11.1.3 to 11.1.4 (FreeTubeApp#5220) Bump stylelint from 16.6.0 to 16.6.1 in the stylelint group (FreeTubeApp#5219) Add missing IPC channel constants (FreeTubeApp#5216)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch settings sections and form elements to created lifecycle hook
Pull Request Type
Related issue
Part of Development Chore: Performance: Switch from
mountedtocreatedhook, where possible to avoid unnecessary component updatesDescription
The
mountedlifecycle hook is triggered after the component has been rendered and has been added to the DOM, thecreatedlifecycle hook is after the component instance has been created, so props and computed properties can be accessed as well as the watchers being active. So to set the default value of a form element for example, we want to use thecreatedlifecycle hook, as setting that in themountedhook will trigger a re-render and changes to the DOM.There are of course exceptions, if you want to show a loading symbol, then fetching the data and setting values in the mounted hook is a great idea, because then the user will see the loading icon while your stuff is running.
Testing
Desktop