Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor performance improvements to the Hashtag view #5927

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Minor performance improvements to the Hashtag view #5927

merged 1 commit into from
Oct 24, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 23, 2024

Minor performance improvements to the Hashtag view

Pull Request Type

  • Performance improvement

Related issue

#5825 (comment)

Description

This pull request implements two small performance improvements to the hashtag view. The first one is that we don't have to call resetData() in the mounted hook, as at the time that the mounted hook is called all the fields still have their default values. The second one is to only watch the hashtag param on the current route object, as that is the only property that could change while you are on the hashtag page.

Testing

  1. Paste https://www.youtube.com/hashtag/shorts into the search bar and hit enter
  2. It should show the hashtag page for #shorts
  3. Paste https://www.youtube.com/hashtag/asmr into the search bar and hit enter
  4. It should switch to the hashtag page for #asmr

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version:

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 23, 2024 21:20
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 23, 2024
@FreeTubeBot FreeTubeBot merged commit f6e7344 into FreeTubeApp:development Oct 24, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 24, 2024
@absidue absidue deleted the hashtag-perf branch October 24, 2024 13:08
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
@absidue @Soham456
Minor performance improvements to the Hashtag view (FreeTubeApp#5927)
3c6b7bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr @FreeTubeBot