Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for channel's Courses tab #6641

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Add support for channel's Courses tab #6641

wants to merge 2 commits into from

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Jan 25, 2025 •
edited
Loading

Add support for channel's Courses tab

Pull Request Type

  • Bugfix - fixes some issues with podcasts and releases as well
  • Feature Implementation - add support for channel's Courses tab

Related issue

iv-org/invidious#5144

Dependent on:
LuanRT/YouTube.js#883
iv-org/invidious#5158

Description

This PR adds support for the courses tab on the channel page for both local api and Invidious API

Screenshots

Testing

test 1

test 2

test 3

Desktop

  • OS: Fedora Linux
  • OS Version: 41
  • FreeTube version: latest nightly

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-channel-courses-tab branch from 83ea087 to 0f794c7 Compare January 25, 2025 19:41
@ShareASmile ShareASmile mentioned this pull request Jan 28, 2025
Open
6 tasks
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-channel-courses-tab branch from 0f794c7 to ae0a148 Compare January 30, 2025 17:20
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-channel-courses-tab branch from ae0a148 to 7a4c824 Compare February 10, 2025 18:36
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-channel-courses-tab branch from 7a4c824 to 27f1535 Compare February 20, 2025 14:46
@absidue
Copy link
Member

absidue commented Feb 23, 2025

As a YouTube.js update with the required changes was released and is being used on the development branch, what would you like to do with this pull request? Wait until the changes on the Invidious side are merged or proceed with a local API implementation first and follow up with an Invidious implementation once the relevant changes have landed on their side?

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-channel-courses-tab branch from 27f1535 to 1af3bed Compare February 26, 2025 23:02
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review February 26, 2025 23:03
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 26, 2025 23:03
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 26, 2025
PikachuEXE
PikachuEXE previously approved these changes Feb 27, 2025
View reviewed changes
@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-channel-courses-tab branch from 2081cb0 to 695b013 Compare March 2, 2025 20:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@absidue absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 2, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Mar 2, 2025
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error with IV API when navigating towards this courses playlist

VirtualBoxVM_2Zd9PiFHIR.mp4

Error with the Local API when starting to watch the courses playlist

VirtualBoxVM_8WkCfT3lLT.mp4

Edit:

Error when using IV API to watch one of the courses playlists

VirtualBoxVM_lC9rwdmDB7

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Mar 2, 2025 •
edited
Loading

Error with IV API when navigating towards this courses playlist
VirtualBoxVM_2Zd9PiFHIR.mp4

Error with the Local API when starting to watch the courses playlist
VirtualBoxVM_8WkCfT3lLT.mp4

The error with invidious api is a bug in invidious (seems to be because you have to pay to watch one of the videos). See: https://inv.nadeko.net/playlist?list=PLmdFyQYShrjfOiKmTtgQFsdorN-0Aq2uJ in a browser

The local api error is because we have the same video showing up multiple times in the playlist

(both of these issues can happen outside of this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue left review comments

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChunkyProgrammer @absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc