Make extensions use typed methods Minz_Request::paramString and Minz_Session::paramString #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inz_Session::paramString instead
…inz_Request::paramString instead
Frenzie
reviewed
Nov 18, 2023
| FreshRSS_Context::$user_conf->image_proxy_scheme_default = Minz_Request::param('image_proxy_scheme_default', self::SCHEME_DEFAULT); | ||
| FreshRSS_Context::$user_conf->image_proxy_scheme_include = Minz_Request::param('image_proxy_scheme_include', ''); | ||
| FreshRSS_Context::$user_conf->image_proxy_url_encode = Minz_Request::param('image_proxy_url_encode', ''); | ||
| FreshRSS_Context::$user_conf->image_proxy_url = Minz_Request::paramString('image_proxy_url', true) ?: self::PROXY_URL; |
There was a problem hiding this comment.
Is that null coalescing parameter thing equivalent to isset()?
|
Looks good 👍🏻 |
I'm actually using CustomJS myself so that got the most testing :) It's been working fine so far. No errors in apache or frss logs and no other issues afaict. Using latest docker image (e4e587aeecf5). |
|
Did quick test with with Dockerfile-Oldest, no issues. |
|
Thanks for the tests 👍🏻 |
pfactum
added a commit
to pfactum/freshrss-greader-redate
that referenced
this pull request
Dec 24, 2023
Follow FreshRSS/Extensions#181 and use `Minz_Request::paramBoolean()` instead of `Minz_Request::param()` + typecasting. Fixes: javerous#6 Signed-off-by: Oleksandr Natalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per short discussion in PR #5830:
FreshRSS/FreshRSS#5830 (comment)
FreshRSS/FreshRSS#5830 (comment)
Tested the 3 extensions with actual changes in docker container running
d2aef84827ee freshrss/freshrss:edge: