-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n improved: dotted path -> dot-notation #6317
Conversation
app/i18n/he/sub.php
Outdated
@@ -127,12 +127,12 @@ | |||
'xpath' => 'XPath for:', // TODO | |||
), | |||
'json_dotpath' => array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename the key json_dotpath
too? (f.e. json_dotnotation
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
But there are much more "dotpath" attributes/variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep them as is typical in English, meaning dot notation, not dot-notation or dotnotation.
@Frenzie I would agree that |
Note that the ESLint configuration for example uses dot-notation as opposed to dot_notation or dotNotation but all of those refer to "dot notation". |
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Frans de Jonge <[email protected]>
Co-authored-by: Frans de Jonge <[email protected]>
Co-authored-by: Frans de Jonge <[email protected]>
Co-authored-by: Frans de Jonge <[email protected]>
I think we should update the name of the file |
could we merge this PR first and do the refactoring in another PR? It would reduce double work for the translators :) |
Fine by me, and better for future git blame really, though I'm not really sure what difference it'd make to the translations? |
right now they translate |
Ref. #5662
see discussion there #5662 (comment)
Changes proposed in this pull request:
dotted path
->dot-notation
dotted path
->dot-notated
Pull request checklist: