Improve aside feed bar #6446
Merged
Improve aside feed bar #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * A few fixes --------- Co-authored-by: Luc <[email protected]> Co-authored-by: Alexandre Alapetite <[email protected]>
* phpstan level 7 for updateController.php * phpstan level 7 for updateController.php * Minor array syntax --------- Co-authored-by: Luc <[email protected]> Co-authored-by: Alexandre Alapetite <[email protected]>
* docs: language table added * Update 05_Configuration.md * Update 05_Configuration.md * french docs * Unicode quote and a few fixes (Same search&replace aslo applied to a few other files) --------- Co-authored-by: Alexandre Alapetite <[email protected]>
#fix FreshRSS#5248 Co-authored-by: maTh <[email protected]>
* Add compatibility with MacOS for `paste` command * Addition to .editorconfig
Fix regression from FreshRSS#5315 which indroduced a bug for cached feeds. We now update the `lastSeen` property of entries to account for the fact that they are unchanged but still existing.
Co-authored-by: Luc <[email protected]>
…ocumentation (FreshRSS#5349) * i18n * Update sub.php * Update app/i18n/fr/sub.php Co-authored-by: Alexandre Alapetite <[email protected]> * fix target="_blank" --------- Co-authored-by: Alexandre Alapetite <[email protected]>
https://alpinelinux.org/posts/Alpine-3.18.0-released.html Minor updates with Apache 2.4.57 and PHP 8.1.19
* delete 04_Changing_source_code.md * make pot --------- Co-authored-by: Alexandre Alapetite <[email protected]>
* Typed view model classes * Add ability to provide a typed view model class to a controller * Use `::class` instead of string for referring to classes * Examplified with `stats` and `javascript` controllers / views (more to do) * Also useful for extensions (my usecase today), which did not have the ability to define own view model attributes before. * Typo
* comments added for each step * infos about FreshRSS added in first step * Remove reference to Kriss and Leed from install page I do not find that informative, and quite confusing. Moved to readme instead. --------- Co-authored-by: Alexandre Alapetite <[email protected]>
* PHPMailer 6.8.0 https://github.com/PHPMailer/PHPMailer/releases/tag/v6.8.0 https://github.com/PHPMailer/PHPMailer/releases * Exclude unused DSNConfigurator
Before, the system configuration was linked to the user parameter while the user configuration was linked to the system parameter. This was an issue when trying to retrieve some kind of configuration value in an extension. Now, the configurations are properly linked to their parameters.
* Fix logs pagination Regression from FreshRSS#5269 * Add better default
…#5400) * PHPStan Level 7 for Minz_Request * PHPStan Level 7 for FreshRSS_Feed * PHPStan Level 7 for Minz_Error
* Fix again updateLastSeenUnchanged FreshRSS#5382 was not good enough to fix markAsReadUponGone and introduced a regression in `entry.lastSeen`. New approach. Follow-up of FreshRSS#5315 * Minor change of mind * Fix handling of lastSeen entry.lastSeen was not always correctly initialised, and sometimes overriden
Forgotten from FreshRSS#5404
Whitespace strings, empty strings, 0 are all problematic when working with GUIDs. so avoid them.
* PHPStan Level 7 complete * Start PHPStan Level 8 * Forgot exclude .phtml
* Fix favicon fetching while using proxies This ensures that if curl_options are defined in config.php, those settings are respected while fetching favicons. Fixes FreshRSS#4951 * Change options priority * Credits keep alphabticorder --------- Co-authored-by: Alexandre Alapetite <[email protected]>
* Update Translate.php * Small improvements --------- Co-authored-by: Alexandre Alapetite <[email protected]>
Alkarex
reviewed
Jul 8, 2024
Alkarex
reviewed
Jul 8, 2024
Alkarex
reviewed
Jul 8, 2024
Alkarex
reviewed
Jul 8, 2024
Alkarex
reviewed
Jul 8, 2024
Alkarex
reviewed
Jul 8, 2024
| 'no_selected' => 'No feed selected.', | ||
| 'number_entries' => '%d articles', | ||
| 'open_feed' => 'Open feed %s', |
There was a problem hiding this comment.
I would have preferred Open feed instead of Open feed %s but no big deal
There was a problem hiding this comment.
I understand.
Why I chose with the %s: It is the tooltip that shows the complete feed name, that could be cropped in the side bar.
There was a problem hiding this comment.
Alright, makes sense. Would be good to have the same for the user labels
|
@math-GH Ups, it looks like the menu for the labels is not working anymore
|
2 tasks
|
@Alkarex Thanks! It led me to another potential bug :) |
This was referenced Jul 19, 2024
Merged
|
Regression #6735 |
|
Another regression #6737 |
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feed sidebar needs some improvements under the hood in HTML
where this improvement started....
hover background = clickable link
before:
(see the mouse pointer. hand = hyperlink, arrow = no hyperlink)
after:
Expand category
Before:
bad used
<a href="#">for the expanding icon. It is not a real link.After:
<button>instead of<a>. This button has a much more bigger clickable area. It has got atitle="expand category". The icon of this button changes color shade, while hovering over the button but does not change while hovering over the category namemute icon
before:
Mute icons have impact on the aligned feeds:
after:
feeds are aligned. Mute icon is placed still good visible between favicon and feed name
mouse over text feed
before:
If the feed is empty (orange) then a mouse over text is shown.
No information is given what the red icon means
If the feed has an error, an information text is displayed
after:
mouse over text:
"open feed [+feed name]" (important for long feed names, that are cropped at the end. So the complete feed name is readable. This text highlights that the user can open here the feed to read it.
Information is given, if the feed ist empty
Information is given, if the feed is muted
Information ist given, if there is an error
Error information is given. The "triangle warning" icon is added
feed drop down menu
before:
if a feed is empty a mouse over text is shown whole hovering over the drop down menu
after:
no mouse over text
mouse over between feed name/link and cog icon/drop down menu icon
after:
the feed drop down icon has another mouse over text than the feed name/link.
The cog icon has a bit transparency while hovering over the name and has no transparency while hovering over the drop down menu icon. It is very useful for the user to understand that there are 2 different actions near in 1 line.
similar on category level
favicon is linked too
before:
the favion was no link to open the feed
after:
it is now linked too
Pull request checklist: