Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP Headers option #6820

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Add HTTP Headers option #6820

merged 4 commits into from
Sep 21, 2024

Conversation

ev-gor
Copy link
Contributor

@ev-gor ev-gor commented Sep 21, 2024

Closes #6784

Changes proposed in this pull request:

  • 'HTTP Headers' field was added to 'Add' and 'Update' subscription forms
  • Values from this field are saved by feed/subscription controller
  • A title and a hint for the field were added to lang files

How to test the feature manually:

  1. Open 'Add' form for a new feed or 'Update' form for an existing one.
  2. Add your HTTP headers to 'HTTP headers' field.
  3. Save the form and update the feed.

Pull request checklist:

  • clear commit messages
  • code manually tested

@Alkarex Alkarex added this to the 1.25.0 milestone Sep 21, 2024
@Alkarex
Copy link
Member

Alkarex commented Sep 21, 2024

There is an encoding issue to fix. Looking at it

@Alkarex
Copy link
Member

Alkarex commented Sep 21, 2024

Let me address the encoding issue in another PR, as it affects a few other fields as well.
Thanks, and please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

@Alkarex Alkarex merged commit e9398f3 into FreshRSS:edge Sep 21, 2024
2 checks passed
@Alkarex
Copy link
Member

Alkarex commented Sep 21, 2024

@ev-gor Could you please test #6821 with special characters such as <'&"> ?

@ev-gor
Copy link
Contributor Author

ev-gor commented Sep 22, 2024

@Alkarex Yes, it works.

Before a server received a header:
authorization: 'Bearer &lt;TOKEN&gt;&amp;'some'&amp;&quot;other&quot;'

Now:
authorization: 'Bearer <Token>&'some'&"other"'

@Alkarex
Copy link
Member

Alkarex commented Sep 22, 2024

Excellent. Thanks for the feedback. Additional tests on all the other fields also welcome.

@Nikkiiw
Copy link

Nikkiiw commented Dec 24, 2024

how to add a referer?
thx!

@Frenzie
Copy link
Member

Frenzie commented Dec 24, 2024

Under advanced, like this:

image

Referer: https://example.com/page?q=123

(The typo-looking spelling of referer is intentional)

@Alkarex
Copy link
Member

Alkarex commented Dec 24, 2024

We could add a Referer example in the help box underneath. PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Setting Request Headers like Authorization Headers
4 participants