refactor: update phpunit to v11 and run rector with phpunit set list

FriendsOfCXML · Jun 10, 2024 · e7fb8b1 · e7fb8b1
1 parent 6d7688c
commit e7fb8b1
Show file tree

Hide file tree

Showing 16 changed files with 31 additions and 20 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -22,11 +22,6 @@
         '@PhpCsFixer:risky' => true,
         '@Symfony' => true,
         '@Symfony:risky' => false,
-        'native_function_invocation' => [
-            'include' => ['@internal'],
-            'scope' => 'namespaced',
-            'strict' => false,
-        ],
         'nullable_type_declaration_for_default_null_value' => false,
         'void_return' => true,
         'random_api_migration' => true,

diff --git a/composer.json b/composer.json
@@ -36,7 +36,7 @@
     "symfony/routing": "If you want to use SelfAwareProfileRequestHandler"
   },
   "require-dev": {
-    "phpunit/phpunit": "^10",
+    "phpunit/phpunit": "^11",
     "phpstan/phpstan": "^1.11.0",
     "friendsofphp/php-cs-fixer": "*",
     "php-parallel-lint/php-parallel-lint": "*",

diff --git a/rector.php b/rector.php
@@ -4,6 +4,7 @@
 
 use Rector\Caching\ValueObject\Storage\FileCacheStorage;
 use Rector\Config\RectorConfig;
+use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Set\ValueObject\SetList;
 use Rector\Symfony\Set\JMSSetList;
 
@@ -14,6 +15,9 @@
     ])
     ->withSets([
         JMSSetList::ANNOTATIONS_TO_ATTRIBUTES,
+        PHPUnitSetList::PHPUNIT_100,
+        PHPUnitSetList::PHPUNIT_CODE_QUALITY,
+        PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTES,
         SetList::TYPE_DECLARATION,
         SetList::CODE_QUALITY,
         SetList::CODING_STYLE,

diff --git a/tests/CXmlTest/Builder/OrderRequestBuilderTest.php b/tests/CXmlTest/Builder/OrderRequestBuilderTest.php
@@ -11,14 +11,15 @@
 use CXml\Payload\PayloadIdentityFactoryInterface;
 use CXml\Serializer;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 use function file_get_contents;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class OrderRequestBuilderTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     public function testFromPunchOutOrderMessage(): void

diff --git a/tests/CXmlTest/Handling/HandlerTest.php b/tests/CXmlTest/Handling/HandlerTest.php
@@ -16,15 +16,16 @@
 use CXml\Processor\Processor;
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 use function file_get_contents;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class HandlerTest extends TestCase
 {
     public static function getEndpointData(): iterable

diff --git a/tests/CXmlTest/Model/OrderRequestTest.php b/tests/CXmlTest/Model/OrderRequestTest.php
@@ -30,12 +30,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class OrderRequestTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Model/ProductActivityMessageTest.php b/tests/CXmlTest/Model/ProductActivityMessageTest.php
@@ -18,12 +18,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class ProductActivityMessageTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Model/PunchOutSetupRequestTest.php b/tests/CXmlTest/Model/PunchOutSetupRequestTest.php
@@ -28,13 +28,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- *
- * @coversNothing
  */
+#[CoversNothing]
 final class PunchOutSetupRequestTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Model/PunchoutOrderMessageAdvancedPricingTest.php b/tests/CXmlTest/Model/PunchoutOrderMessageAdvancedPricingTest.php
@@ -19,12 +19,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class PunchoutOrderMessageAdvancedPricingTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Model/PunchoutOrderMessageTest.php b/tests/CXmlTest/Model/PunchoutOrderMessageTest.php
@@ -19,12 +19,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class PunchoutOrderMessageTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Model/QuoteMessageTest.php b/tests/CXmlTest/Model/QuoteMessageTest.php
@@ -24,12 +24,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class QuoteMessageTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Model/SerializerTest.php b/tests/CXmlTest/Model/SerializerTest.php
@@ -22,13 +22,14 @@
 use CXml\Model\Status;
 use CXml\Serializer;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class SerializerTest extends TestCase
 {
     public function testSerializeSimpleRequest(): void

diff --git a/tests/CXmlTest/Model/ShipNoticeRequestTest.php b/tests/CXmlTest/Model/ShipNoticeRequestTest.php
@@ -17,12 +17,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class ShipNoticeRequestTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Model/StatusUpdateRequestTest.php b/tests/CXmlTest/Model/StatusUpdateRequestTest.php
@@ -13,12 +13,13 @@
 use CXml\Serializer;
 use CXml\Validation\DtdValidator;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class StatusUpdateRequestTest extends TestCase implements PayloadIdentityFactoryInterface
 {
     private DtdValidator $dtdValidator;

diff --git a/tests/CXmlTest/Payload/DefaultPayloadIdentityFactoryTest.php b/tests/CXmlTest/Payload/DefaultPayloadIdentityFactoryTest.php
@@ -6,12 +6,13 @@
 
 use CXml\Payload\DefaultPayloadIdentityFactory;
 use DateTime;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class DefaultPayloadIdentityFactoryTest extends TestCase
 {
     public function testGenerateNewPayloadId(): void

diff --git a/tests/CXmlTest/Validation/MessageValidatorTest.php b/tests/CXmlTest/Validation/MessageValidatorTest.php
@@ -6,14 +6,15 @@
 
 use CXml\Validation\DtdValidator;
 use CXml\Validation\Exception\CXmlInvalidException;
+use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\TestCase;
 
 use function file_get_contents;
 
 /**
  * @internal
- * @coversNothing
  */
+#[CoversNothing]
 final class MessageValidatorTest extends TestCase
 {
     private DtdValidator $dtdValidator;