Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bake task for filter collections #303

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Bake task for filter collections #303

merged 5 commits into from
Nov 9, 2020

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Nov 9, 2020

Replaces #300 if is green.

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #303 (eeb80e4) into master (8376995) will decrease coverage by 0.53%.
The diff coverage is 90.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
- Coverage     93.92%   93.38%   -0.54%     
- Complexity      204      227      +23     
============================================
  Files            17       18       +1     
  Lines           510      590      +80     
============================================
+ Hits            479      551      +72     
- Misses           31       39       +8     
Impacted Files Coverage Δ Complexity Δ
src/Command/BakeFilterCollectionCommand.php 89.74% <89.74%> (ø) 23.00 <23.00> (?)
src/Model/Filter/Base.php 93.97% <100.00%> (+0.07%) 37.00 <0.00> (ø)
src/Processor.php 96.96% <100.00%> (+0.09%) 13.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8376995...eeb80e4. Read the comment docs.

@dereuromark
Copy link
Member Author

🎉

@ADmad ADmad merged commit ee0b26f into master Nov 9, 2020
@ADmad ADmad deleted the bake-task-ci branch November 9, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants