Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Routing.generate #423

Closed
BenjaminPoutriquet35800 opened this issue Dec 24, 2021 · 4 comments
Closed

Bug - Routing.generate #423

BenjaminPoutriquet35800 opened this issue Dec 24, 2021 · 4 comments

Comments

@BenjaminPoutriquet35800
Copy link

Hi :)

I am having a problem when I try to generate one route from JS.

Explanation :

Controller definition :
route_def_controller

Render route from twig :
render_twig

But from JS :
route_from_js

Router does nothing :(

Regards
@BenjaminPoutriquet35800
Copy link
Author

I think problem is this var : hasDefault in if condition
image

gautierderuette added a commit to gautierderuette/FOSJsRoutingBundle that referenced this issue Dec 24, 2021
@gautierderuette
Correct a bug when there is defaults fiekd
bfc779e 
This is to correct issue FriendsOfSymfony#423
@gautierderuette gautierderuette mentioned this issue Dec 24, 2021
Closed
@tobias-93
Copy link
Collaborator

Hi @BenjaminPoutriquet35800, explicit inclusion of defaults using the exclamation mark was not supported yet in this bundle. I have added it in 22029de, can you try if the dev-master branch works for you? Thanks

@BenjaminPoutriquet35800
Copy link
Author

Hi @tobias-93

Awesome that's good ! Really thanks <3

Regards

@tobias-93
Copy link
Collaborator

Version 3.1.0 has been released with the added functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobias-93 @BenjaminPoutriquet35800