Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stable PHP 8 releases in the CI #2278

Closed
wants to merge 12 commits into from
Closed

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 30, 2020

No description provided.

@GuilhemN
Copy link
Member

I pushed some commits to your branch, I hope you don't mind.

I upgraded the code to phpunit 9 as it's the only version supporting php 8. The ignore requirements is back due to JMS\serializer.
There are some failures remaining, I'm not sure yet where do they come from, they may be related to some changes in php 8.

@GuilhemN
Copy link
Member

Wow the battle was tough... But I won against phpunit and php 8 :D

This is ready for me, I can also do the merge in 3.x if you want.

@GuilhemN GuilhemN marked this pull request as ready for review November 30, 2020 20:17
@DenchikBY
Copy link

Hi, do you plan rework annotations in this PR to support php 8 format?

@xabbuh
Copy link
Member Author

xabbuh commented Dec 4, 2020

If you are talking about support for PHP 8 attributes, that's not in the scope of this PR. But if you are interested in giving it a try, please feel free to open a separate pull request.

@kevinpapst
Copy link
Contributor

kevinpapst commented Dec 10, 2020

Can we help to push this PR and the upcoming release that will include it?

@GuilhemN
Copy link
Member

Oops sorry I just realized this PR was also targetting 2.x and I could have completed it instead of pushing to #2280... I guess I wasn't well awaken when I did that :x

Anyway it's merged now so too late I suppose... I'm closing this PR in favor of #2280 :)

@GuilhemN GuilhemN closed this Dec 10, 2020
@xabbuh xabbuh deleted the php8 branch December 11, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants