-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use stable PHP 8 releases in the CI #2278
Conversation
I pushed some commits to your branch, I hope you don't mind. I upgraded the code to phpunit 9 as it's the only version supporting php 8. The ignore requirements is back due to JMS\serializer. |
Wow the battle was tough... But I won against phpunit and php 8 :D This is ready for me, I can also do the merge in 3.x if you want. |
Hi, do you plan rework annotations in this PR to support php 8 format? |
If you are talking about support for PHP 8 attributes, that's not in the scope of this PR. But if you are interested in giving it a try, please feel free to open a separate pull request. |
Can we help to push this PR and the upcoming release that will include it? |
No description provided.