fix(runtime-logger): Use unique names for internal plugins (#178)

Fryuni · Nov 12, 2024 · 23b89bf · 23b89bf
1 parent aa73961
commit 23b89bf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/many-poems-greet.md b/.changeset/many-poems-greet.md
@@ -0,0 +1,5 @@
+---
+'@inox-tools/runtime-logger': patch
+---
+
+Fixes internal plugins having the same name causing incorrect warnings when building
diff --git a/packages/runtime-logger/src/buildLoggerPlugin.ts b/packages/runtime-logger/src/buildLoggerPlugin.ts
@@ -5,7 +5,7 @@ import { INTERNAL_MODULE } from './internalPlugin.js';
 const MODULE_PREFIX = '@it-astro:logger:';
 const RESOLVED_MODULE_PREFIX = '\x00@it-astro:logger:';
 
-const pluginName = '@inox-tools/runtime-logger/dev';
+const pluginName = '@inox-tools/runtime-logger/integrations';
 
 export const buildLoggerPlugin = (loggers: Map<string, AstroIntegrationLogger>): Plugin => {
 	(globalThis as any)[Symbol.for(pluginName)] = loggers;

diff --git a/packages/runtime-logger/src/devLoggerPlugin.ts b/packages/runtime-logger/src/devLoggerPlugin.ts
@@ -4,7 +4,7 @@ import type { AstroIntegrationLogger } from 'astro';
 const MODULE_PREFIX = '@it-astro:logger:';
 const RESOLVED_MODULE_PREFIX = '\x00@it-astro:logger:';
 
-const pluginName = '@inox-tools/runtime-logger/dev';
+const pluginName = '@inox-tools/runtime-logger/integrations';
 
 export const devLoggerPlugin = (loggers: Map<string, AstroIntegrationLogger>): Plugin => {
 	(globalThis as any)[Symbol.for(pluginName)] = loggers;

diff --git a/packages/runtime-logger/src/projectLoggerPlugin.ts b/packages/runtime-logger/src/projectLoggerPlugin.ts
@@ -5,7 +5,7 @@ const VIRTUAL_MODULE = '@it-astro:logger';
 const RESOLVED_VIRTUAL_MODULE = '\x00@it-astro:logger?';
 
 export const projectLoggerPlugin = (rootPath: string): Plugin => ({
-	name: '@inox-tools/runtime-logger/dev',
+	name: '@inox-tools/runtime-logger/project',
 	resolveId(id, importer) {
 		if (id === VIRTUAL_MODULE) {
 			const params = new URLSearchParams();