Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct use of eval-after-load #677

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Correct use of eval-after-load #677

merged 1 commit into from
Nov 21, 2016

Conversation

Silex
Copy link
Contributor

@Silex Silex commented Nov 20, 2016

With a symbol, only the file providing the feature triggers the
eval-after-load. With a string, any file named the same way triggers
it. This is problematic for custom configurations named after
packages.

@Fuco1
Copy link
Owner

Fuco1 commented Nov 21, 2016

Did you check all the packages and the features they provide? I'm not sure if it is named the same in each case.

@Silex
Copy link
Contributor Author

Silex commented Nov 21, 2016

Hum, I didn't think of that possibility! I'll try to check

With a symbol, only the file providing the feature triggers the
eval-after-load. With a string, any file named the same way triggers
it. This is problematic for custom configurations named after
packages.
@Silex
Copy link
Contributor Author

Silex commented Nov 21, 2016

Ok I verified, and I also corrected things I missed in the other forms :-)

I couldn't find "latex" and "python" packages tho. Maybe those are rarely used packages?

EDIT found python.el, it provides 'python so all is ok. Can't find latex.el

@Fuco1
Copy link
Owner

Fuco1 commented Nov 21, 2016

There is (provide 'tex-mode) which defines latex-mode but there is also auctex which has a file latex.el which provides latex feature (it also provides tex and tex-site and gods know what else... nobody understands how that loads :D

Hooking on tex-mode and latex should be enough I think.

@Silex
Copy link
Contributor Author

Silex commented Nov 21, 2016

A'ight

@Fuco1 Fuco1 merged commit b661715 into Fuco1:master Nov 21, 2016
jojojames pushed a commit to jojojames/smartparens that referenced this pull request Mar 31, 2017
With a symbol, only the file providing the feature triggers the
eval-after-load. With a string, any file named the same way triggers
it. This is problematic for custom configurations named after
packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants