Support fsharp-mode #714
Merged
Support fsharp-mode #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename smartparens-ocaml to smartparens-ml: The OCaml local pair definitions apply for all ML based languages (like F#).
|
F# is basically an OCaml dialect on the CLR. The same problems discussed in |
|
One thing that slightly bothers me is that if someone required the file directly their config will break now. But I think that's a minimal number of people and if we put a note large enough in the release notes it should be fine. Thanks for the contribution! |
jojojames
pushed a commit
to jojojames/smartparens
that referenced
this pull request
Mar 31, 2017
Rename smartparens-ocaml to smartparens-ml The OCaml local pair definitions apply for all ML based languages (like F#).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename smartparens-ocaml to smartparens-ml: The OCaml local pair
definitions apply for all ML based languages (like F#).