Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apostrophe in ESS comments #769

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Conversation

jabranham
Copy link
Collaborator

I'm not super familiar with smartparens, but this seems to fix #745 for me.

@Fuco1
Copy link
Owner

Fuco1 commented Jul 5, 2017

Hi, thanks for taking the time to make the patch. I'm going to merge it because it is better than no solution, but think about the following questions, maybe we can come up with something better:

If the problem is with the insertion of two ' when you are trying to type a contraction maybe we can use the predicate sp-point-after-word-p which is non-nil here| but not here | where we maybe want to insert a pair.

Is the '' quote pair useful at all in R? Does it mean char or string? Maybe we could disable it completely if it's useless.

@Fuco1 Fuco1 merged commit b20f7d0 into Fuco1:master Jul 5, 2017
Fuco1 added a commit that referenced this pull request Jul 5, 2017
@jabranham
Copy link
Collaborator Author

Thanks, sp-point-after-word-p sounds promising, I'll look into it later.

Yes, '' starts characters in R, so we can't just disable it.

@jabranham jabranham deleted the fix-apostraph-in-ess branch July 5, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extra ' in ess comments
2 participants