-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for different decimal scenarios #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is published in NPM with version **** |
661553a
to
184069f
Compare
bitzoic
previously approved these changes
Feb 22, 2024
@K1-R1 @bitzoic @LuizAsFight requesting an approval on this one please! 🟢 |
83e4a2d
to
ea63556
Compare
bitzoic
approved these changes
Mar 1, 2024
LuizAsFight
approved these changes
Mar 3, 2024
LuizAsFight
pushed a commit
that referenced
this pull request
Mar 13, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @fuel-bridge/[email protected] ### Minor Changes - Add pnpm audit to CI and migrate dependencies to safe versions, by [@DefiCake](https://github.com/DefiCake) (See [#126](#126)) - Update to forc 0.49.1, by [@DefiCake](https://github.com/DefiCake) (See [#119](#119)) - Workaround current fuel-rs small configurables (u8) limitation. Add tests for decimal conversion, by [@DefiCake](https://github.com/DefiCake) (See [#123](#123)) - Bump forc to 0.51, by [@DefiCake](https://github.com/DefiCake) (See [#141](#141)) - Remove b256-u256 conversions, use new sway utils that implement these features, by [@DefiCake](https://github.com/DefiCake) (See [#143](#143)) ### Patch Changes - Bump forc to 0.50.0, by [@DefiCake](https://github.com/DefiCake) (See [#124](#124)) - Add CORS to deployment server + update typescript SDK, by [@LuizAsFight](https://github.com/LuizAsFight) (See [#134](#134)) - Bump fuels to 0.55.0, by [@DefiCake](https://github.com/DefiCake) (See [#122](#122)) ## @fuel-bridge/[email protected] ### Minor Changes - Add pnpm audit to CI and migrate dependencies to safe versions, by [@DefiCake](https://github.com/DefiCake) (See [#126](#126)) - Update to forc 0.49.1, by [@DefiCake](https://github.com/DefiCake) (See [#119](#119)) ### Patch Changes - Bump fuels to 0.55.0, by [@DefiCake](https://github.com/DefiCake) (See [#122](#122)) ## @fuel-bridge/[email protected] ### Minor Changes - Add pnpm audit to CI and migrate dependencies to safe versions, by [@DefiCake](https://github.com/DefiCake) (See [#126](#126)) ### Patch Changes - Deployed beta5devnet, by [@DefiCake](https://github.com/DefiCake) (See [#114](#114)) - Add CORS to deployment server + update typescript SDK, by [@LuizAsFight](https://github.com/LuizAsFight) (See [#134](#134)) ## @fuel-bridge/[email protected] ### Minor Changes - Add pnpm audit to CI and migrate dependencies to safe versions, by [@DefiCake](https://github.com/DefiCake) (See [#126](#126)) ### Patch Changes - Add CORS to deployment server + update typescript SDK, by [@LuizAsFight](https://github.com/LuizAsFight) (See [#134](#134)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests to cover different decimal scenarios.
It also workarounds an ongoing issue on small configurables (u8, booleans): FuelLabs/fuels-rs#1265. I will open an issue as soon as this PR is merged to go back to u8 configurables when the fuels-rs bug is fixed.
No major changes in the sway code. Decimal conversion is working fine, I only had to add the test cases.