Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for different decimal scenarios #123

Merged
merged 8 commits into from
Mar 3, 2024
Merged

Conversation

DefiCake
Copy link
Member

@DefiCake DefiCake commented Feb 6, 2024

This PR adds tests to cover different decimal scenarios.

It also workarounds an ongoing issue on small configurables (u8, booleans): FuelLabs/fuels-rs#1265. I will open an issue as soon as this PR is merged to go back to u8 configurables when the fuels-rs bug is fixed.

No major changes in the sway code. Decimal conversion is working fine, I only had to add the test cases.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

This PR is published in NPM with version ****

@DefiCake DefiCake force-pushed the deficake/test-decimals branch from 661553a to 184069f Compare February 21, 2024 10:11
@DefiCake DefiCake marked this pull request as ready for review February 21, 2024 10:38
bitzoic
bitzoic previously approved these changes Feb 22, 2024
packages/fungible-token/bridge-fungible-token/src/main.sw Outdated Show resolved Hide resolved
@DefiCake
Copy link
Member Author

@K1-R1 @bitzoic @LuizAsFight requesting an approval on this one please! 🟢

@DefiCake DefiCake force-pushed the deficake/test-decimals branch from 83e4a2d to ea63556 Compare February 28, 2024 10:48
@DefiCake DefiCake merged commit e0a30d8 into main Mar 3, 2024
6 checks passed
@DefiCake DefiCake deleted the deficake/test-decimals branch March 3, 2024 22:22
LuizAsFight pushed a commit that referenced this pull request Mar 13, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @fuel-bridge/[email protected]

### Minor Changes

- Add pnpm audit to CI and migrate dependencies to safe versions, by
[@DefiCake](https://github.com/DefiCake) (See
[#126](#126))
- Update to forc 0.49.1, by [@DefiCake](https://github.com/DefiCake)
(See [#119](#119))
- Workaround current fuel-rs small configurables (u8) limitation. Add
tests for decimal conversion, by
[@DefiCake](https://github.com/DefiCake) (See
[#123](#123))
- Bump forc to 0.51, by [@DefiCake](https://github.com/DefiCake) (See
[#141](#141))
- Remove b256-u256 conversions, use new sway utils that implement these
features, by [@DefiCake](https://github.com/DefiCake) (See
[#143](#143))

### Patch Changes

- Bump forc to 0.50.0, by [@DefiCake](https://github.com/DefiCake) (See
[#124](#124))
- Add CORS to deployment server + update typescript SDK, by
[@LuizAsFight](https://github.com/LuizAsFight) (See
[#134](#134))
- Bump fuels to 0.55.0, by [@DefiCake](https://github.com/DefiCake) (See
[#122](#122))

## @fuel-bridge/[email protected]

### Minor Changes

- Add pnpm audit to CI and migrate dependencies to safe versions, by
[@DefiCake](https://github.com/DefiCake) (See
[#126](#126))
- Update to forc 0.49.1, by [@DefiCake](https://github.com/DefiCake)
(See [#119](#119))

### Patch Changes

- Bump fuels to 0.55.0, by [@DefiCake](https://github.com/DefiCake) (See
[#122](#122))

## @fuel-bridge/[email protected]

### Minor Changes

- Add pnpm audit to CI and migrate dependencies to safe versions, by
[@DefiCake](https://github.com/DefiCake) (See
[#126](#126))

### Patch Changes

- Deployed beta5devnet, by [@DefiCake](https://github.com/DefiCake) (See
[#114](#114))
- Add CORS to deployment server + update typescript SDK, by
[@LuizAsFight](https://github.com/LuizAsFight) (See
[#134](#134))

## @fuel-bridge/[email protected]

### Minor Changes

- Add pnpm audit to CI and migrate dependencies to safe versions, by
[@DefiCake](https://github.com/DefiCake) (See
[#126](#126))

### Patch Changes

- Add CORS to deployment server + update typescript SDK, by
[@LuizAsFight](https://github.com/LuizAsFight) (See
[#134](#134))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants