Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: token withdrawal tests using message coin #385

Merged
merged 17 commits into from
Feb 12, 2025
Merged

test: token withdrawal tests using message coin #385

merged 17 commits into from
Feb 12, 2025

Conversation

viraj124
Copy link
Contributor

@viraj124 viraj124 commented Jan 21, 2025 •
edited
Loading

@viraj124 viraj124 requested a review from a team as a code owner January 21, 2025 06:28
@viraj124 viraj124 marked this pull request as draft January 21, 2025 06:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

This PR is published in NPM with version 1.1.0-pr-385-70

@viraj124 viraj124 marked this pull request as ready for review January 21, 2025 09:13
DefiCake
DefiCake reviewed Jan 21, 2025
View reviewed changes
@viraj124 viraj124 changed the title test: token withdrawals tests using message coin test: token withdrawal tests using message coin Jan 21, 2025
@viraj124 viraj124 marked this pull request as draft January 21, 2025 17:06
@viraj124 viraj124 marked this pull request as ready for review January 21, 2025 18:17
DefiCake
DefiCake reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@DefiCake DefiCake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think it could use some polish

PraneshASP
PraneshASP previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@PraneshASP PraneshASP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

DefiCake
DefiCake previously approved these changes Jan 23, 2025
View reviewed changes
@DefiCake DefiCake self-requested a review February 12, 2025 09:49
@viraj124 viraj124 requested a review from PraneshASP February 12, 2025 10:50
@viraj124 viraj124 merged commit 7602794 into main Feb 12, 2025
10 checks passed
@viraj124 viraj124 deleted the viraj124/274-message-coin-withdrawal-test branch February 12, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraneshASP PraneshASP PraneshASP approved these changes

@DefiCake DefiCake DefiCake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(test) Add a integration test case: withdraw with MessageCoin
3 participants
@viraj124 @PraneshASP @DefiCake