feat: optimise run time for integration tests #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viraj124
commented
Feb 5, 2025
viraj124
commented
- closes feat: optimise run time for integration tests #389
DefiCake
reviewed
Feb 13, 2025
| @@ -22,9 +22,13 @@ describe('Proxy', async function () { | |||
|
|
|||
| before(async () => { | |||
| // spinning up all docker containers | |||
| containers = await startContainers(false); | |||
| containers = await startContainers(false, 5050, 4545, 6232); | |||
There was a problem hiding this comment.
Many magic numbers, please name them and use them accordingly
There was a problem hiding this comment.
sorry this is still in progress I referred the wrong issue
Base automatically changed from
viraj124/382-feat-testcontainers-integration
to
main
February 14, 2025 12:24
viraj124
changed the title
DefiCake
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.