ERC20 unit test refactor #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefiCake
force-pushed
the
deficake/erc20-unit-test-refactor
branch
from
416c914 to
b7d90fb
Compare
Braqzen
reviewed
Oct 2, 2023
Comment on lines
+2
to
+3
| import type { BigNumberish, BytesLike } from 'ethers'; | ||
| import { BigNumber as BN, BigNumber, ethers } from 'ethers'; |
There was a problem hiding this comment.
Suggested change
| import type { BigNumberish, BytesLike } from 'ethers'; | |
| import { BigNumber as BN, BigNumber, ethers } from 'ethers'; | |
| import type { BigNumberish, BytesLike } from 'ethers'; | |
| import { BigNumber as BN, ethers } from 'ethers'; |
Haven't seen import type before. Can these two imports be merged?
There was a problem hiding this comment.
To my knowledge they can be merged, but ESLint will complain about it. It was a rule introduced by @luizstacio if I recall correctly, it might have something to do with how the monorepo packages the typings etc.
| return _messageSender; | ||
| } | ||
|
|
||
| function sendMessage(bytes32, bytes calldata) external pure {} |
There was a problem hiding this comment.
What purpose does this empty function serve?
There was a problem hiding this comment.
It is a mock contract - so it just implements the interface to accept these calls.
Braqzen
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
getOrDeployERC721Gatewaythat was pasted from ERC20 gateway by mistake