Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dry running of transactions in the past #2062

Closed
2 of 6 tasks
xgreenx opened this issue Aug 8, 2024 · 1 comment · Fixed by #2661
Closed
2 of 6 tasks

Support dry running of transactions in the past #2062

xgreenx opened this issue Aug 8, 2024 · 1 comment · Fixed by #2661
Assignees
@Dentosal @xgreenx @rafal-ch

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Aug 8, 2024 •
edited by rafal-ch
Loading

Requires first #1995 feature to avoid error in the case of the InMemory storage.

Scope draft:

  • Feature is "roughly" implemented on Green's branch (patch files + branch hotfix/dry_run_may_return)
  • Merge master into above
  • Write test which proves that a transaction can't be executed on the tip of the blockchain, but works on block from the past
  • Consider enabling this feature by a flag different than --debug (allow_historical_dry_run, or smth)
  • Option (?)
  • Clean-up code and cover with tests (if needed)
@xgreenx xgreenx mentioned this issue Aug 8, 2024
Merged
1 task
xgreenx added a commit that referenced this issue Aug 8, 2024
@xgreenx
Don't use historical view during dry run (#2063)
61d18e6 
Due to race conditions dry run may fail with `InMemory` store. I
disabled the usage of the historical view for dry run case until the
future. #2062

### Before requesting review
- [x] I have reviewed the code myself
@xgreenx xgreenx mentioned this issue Sep 17, 2024
Closed
@netrome netrome mentioned this issue Sep 17, 2024
Merged
5 tasks
@rafal-ch
Copy link
Contributor

rafal-ch commented Dec 30, 2024 •
edited
Loading

Add test scenario:
1. Alice has 100 in block 1
2. Alice transfers 50 to Bob in block 2
3. Dry Run - Alice tries to transfer 75 to Charlie in latest block -> FAIL
4. Dry Run - Alice tries to transfer 75 to Charlie in block 1 -> SUCCESS

@Dentosal Dentosal self-assigned this Feb 3, 2025
@Dentosal Dentosal mentioned this issue Feb 3, 2025
Merged
7 tasks
Dentosal added a commit that referenced this issue Feb 10, 2025
@Dentosal
Dry run in the past (#2661)
ed6aa39 
Closes #2062

## Description

Support dry running in past blocks. It's behind the
`--historical-execution` flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dentosal Dentosal

@xgreenx xgreenx

@rafal-ch rafal-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dry run in the past FuelLabs/fuel-core
3 participants
@Dentosal @xgreenx @rafal-ch