Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

message_receipts_proof creates invalid proof if transaction with MessageOut receipt failed #2421

Closed
xgreenx opened this issue Oct 31, 2024 · 0 comments · Fixed by #2478
Closed

message_receipts_proof creates invalid proof if transaction with MessageOut receipt failed #2421

xgreenx opened this issue Oct 31, 2024 · 0 comments · Fixed by #2478
Assignees
@AurelienFT
Labels
bug Something isn't working

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 31, 2024 •
edited
Loading

The message_receipts_proof function creates invalid proof if transaction with MessageOut receipt failed during execution of the block.

The code creates Merkle tree over all MessageOut receipts even if transaction failed. While the message_outbox_root includes only messages from successful transactions.

image image

Definition of done

The user should be able to generate valid proof for blocks containing successful and failed transactions that emit a MessageOut receipt.
@xgreenx xgreenx added the bug Something isn't working label Oct 31, 2024
@AurelienFT AurelienFT mentioned this issue Dec 6, 2024
Merged
5 tasks
AurelienFT added a commit that referenced this issue Dec 12, 2024
@AurelienFT
Ignore receipts from failed transactions in message_receipts_proof (#…
856d5da 
…2478)

Resolves #2421 

In this PR we changed the `message_receipts_proof` to ignore the
receipts from the failed transactions.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore receipts from failed transactions in message_receipts_proof FuelLabs/fuel-core
2 participants
@xgreenx @AurelienFT