Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for balances with (non)retryable messages #2474

Closed
rafal-ch opened this issue Dec 5, 2024 · 0 comments · Fixed by #2505
Closed

Add integration tests for balances with (non)retryable messages #2474

rafal-ch opened this issue Dec 5, 2024 · 0 comments · Fixed by #2505

Comments

@rafal-ch
Copy link
Contributor

rafal-ch commented Dec 5, 2024

Currently our integration tests for "balance(s)" endpoint doesn't check if non/retryable messages are correctly handled. We need to improve the coverage.
@rafal-ch rafal-ch mentioned this issue Dec 17, 2024
Merged
3 tasks
rafal-ch added a commit that referenced this issue Jan 2, 2025
@rafal-ch @xgreenx
Integration test for balances and (non)retryable messages (#2505)
d84306f 
Closes #2474

## Description
This PR changes the following:
1. Adds new test in `tests/tests/relayer.rs` - to ensure that only
**non**-retryable messages contribute to the balance returned from
`balance()`, `balances()` and `coins_to_spend()`[^1] endpoints
2. Modifies the `balance()` test in `tests/tests/balances.rs` to also
include some retryable message which is expected **not** to contribute
to the total balance.
   * for `balances()` and `coins_to_spend()` it was already the case

1<sup>st</sup> test checks the behavior of the actual blockchain
operations while the 2<sup>nd</sup> tests the proper initialization of
the balances index at genesis.

## Checklist
- [X] Breaking changes are clearly marked as such in the PR description
and changelog
- [X] New behavior is reflected in tests

### Before requesting review
- [X] I have reviewed the code myself

[^1]: currently, `coins_to_spend()` is not using indexation, this will
change when [this PR](#2463)
is merged.

---------

Co-authored-by: Green Baneling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integration test for balances and (non)retryable messages FuelLabs/fuel-core
1 participant
@rafal-ch