Log executor metrics only if enabled in config #2323
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft attempt to use "metrics" config param in the executor.
Not sure if this is the way to go because it adds metrics field to
ExecutionOptions
, which in turn is a member of the versionedInputSerializationType
andInputDeserializationType
. This could mean a breaking change.Alternative approach would be to log the metrics in higher layer, ie.: modify the
fn produce_inner<TxSource>()
to get additionalmetrics
parameter (we have access toConfig
in all call-sites). Then after either ofnative_produce_inner()
orwasm_produce_inner()
finishes, the metric values could be calculated from theExecutionResult
.