-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid long heavy tasks in the GraphQL service #2340
Merged
Merged
Changes from 12 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
2fe7bb6
Prepare the GraphQL service for the switching to `async` methods
xgreenx ab5e940
Updated CHANGELOG.md
xgreenx 1782684
Updated all pagination queries to work with the `Stream` instead of `…
xgreenx 5192c95
Making change non-breaking for now
xgreenx feeb816
Updated CHANGELOG.md
xgreenx 4237feb
Avoid long heavy tasks in the GraphQL service
xgreenx 142cd1d
Use correct naming
xgreenx 671e80e
Updated CHANGELOG.md
xgreenx 2354d10
Make closure more readable
xgreenx d982fbc
Apply comment from parent PR
xgreenx c355cd1
Use more clear naming for the logic
xgreenx 7846db4
Merge branch 'feature/async-pagination-queries' into feature/avoid-lo…
xgreenx 5a752bc
Fix flakiness
xgreenx a8c1942
Apply suggestions from code review
xgreenx df80801
Apply comments from PR
xgreenx e414046
Merge branch 'master' into feature/prepare-graphql-for-async
xgreenx 3d1e2d8
Merge branch 'refs/heads/feature/async-pagination-queries' into featu…
xgreenx 8cb24b0
Add link to issue for TODO
xgreenx 74bf964
Merge branch 'master' into feature/prepare-graphql-for-async
xgreenx 3868d45
Merge branch 'feature/prepare-graphql-for-async' into feature/async-p…
xgreenx 678e0be
Use `futures::TryStreamExt`
xgreenx 314cd37
Merge branch 'feature/async-pagination-queries' into feature/avoid-lo…
xgreenx 727b2da
Implemented `yield_each` for the stream allowing other tasks to proceed
xgreenx d5d7934
Merge branch 'refs/heads/master' into feature/async-pagination-queries
xgreenx 73adec0
Merge branch 'feature/async-pagination-queries' into feature/avoid-lo…
xgreenx 5e0ec92
Make CI happy
xgreenx 981b690
Merge branch 'master' into feature/async-pagination-queries
xgreenx 3521a72
Merge with `master`
xgreenx 946f46c
Merge branch 'refs/heads/feature/async-pagination-queries' into featu…
xgreenx c4ad916
Merge branch 'master' into feature/async-pagination-queries
xgreenx 2866da1
Merge branch 'feature/async-pagination-queries' into feature/avoid-lo…
xgreenx d8e159c
Merge branch 'master' into feature/async-pagination-queries
xgreenx c61436e
Merge branch 'feature/async-pagination-queries' into feature/avoid-lo…
xgreenx 71d3692
Merge branch 'master' into feature/async-pagination-queries
xgreenx 35c7184
Merge branch 'master' into feature/async-pagination-queries
xgreenx d8c8c5e
Merge branch 'feature/async-pagination-queries' into feature/avoid-lo…
xgreenx 866f538
Merge branch 'refs/heads/master' into feature/avoid-long-heavy-tasks
xgreenx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this have to be configurable? can we just set it to a global now to reduce the config surface? we have too many options rn :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to make it configurable for now to be able to adjust our performance on the fly. Later we can remove it when we have better ideas about the best value