-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new index for tracking Asset metadata #2445
Open
maschad
wants to merge
289
commits into
master
Choose a base branch
from
mc/feat/index-asset-ids
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+790
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e77f33b.
…e_part_2' into mc/feat/index-asset-ids
…f flag is enabled
…to_spend_cache_part_2
…e_part_2' into mc/feat/index-asset-ids
AurelienFT
changed the base branch from
master
to
rafal_2391_coins_to_spend_cache_part_2
January 10, 2025 12:07
xgreenx
previously approved these changes
Jan 10, 2025
…e_part_2' into mc/feat/index-asset-ids
Base automatically changed from
rafal_2391_coins_to_spend_cache_part_2
to
master
January 13, 2025 15:20
AurelienFT
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xgreenx
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Please merge #2463 first
Linked Issues/PRs
Closes Add indexation
AssetId -> (ContractId, SubId)
#2425Related to Consider
assets
in check-account utility fuels-ts#3373It's based on top of Use indexation cache to satisfy "coins to spend" queries #2463 in order to have access to several mechanisms (like
IndexationError
) implemented previously for other indexes.Description
This introduces a new GraphQL endpoint that returns info about an asset. Similarly to other indexes, the asset metadata index is only available when the client was started with no database and was able to sync from scratch. If the index is not available, this endpoint will return an error:
The off-chain worker indexes
Mint
andBurn
events to store this metadata about anAssetId
.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]