Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(codeowners): gas price service codeowners #2534

Merged
merged 3 commits into from
Jan 6, 2025
Merged

chore(codeowners): gas price service codeowners #2534

merged 3 commits into from
Jan 6, 2025

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Jan 6, 2025

Linked Issues/PRs

Description

Adds myself to the codeowners for gas price service.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Jan 6, 2025
@rymnc rymnc self-assigned this Jan 6, 2025
@rymnc rymnc requested a review from a team January 6, 2025 16:11
MitchTurner
MitchTurner approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@MitchTurner MitchTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@rymnc rymnc enabled auto-merge (squash) January 6, 2025 17:23
@rymnc rymnc merged commit caa89d8 into master Jan 6, 2025
30 of 31 checks passed
@rymnc rymnc deleted the chore/gas-price-service-codeowners branch January 6, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@MitchTurner MitchTurner MitchTurner approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

Assignees

@rymnc rymnc

Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rymnc @MitchTurner @xgreenx