Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault_proving(compression): include block_id in da compressed block headers #2551

Merged
merged 18 commits into from
Jan 15, 2025

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Jan 13, 2025

Linked Issues/PRs

Description

Defines a new version of the CompressedBlockPayload which has a header that contains the block_id, relevant for fault proving.

Also refactored the proptest strategy generation and moved the macro internally so that tests can be ran from IDEs easily.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc self-assigned this Jan 13, 2025
@acerone85
Copy link
Contributor

Added a couple of comments, I don't have any further remarks.
All my comments are suggestions rather than requests, feel free to ignore if you don't agree

@rymnc rymnc linked an issue Jan 15, 2025 that may be closed by this pull request
@rymnc rymnc marked this pull request as ready for review January 15, 2025 08:14
@rymnc rymnc requested review from netrome and acerone85 January 15, 2025 08:14
@rymnc rymnc force-pushed the proving/compressed-header-changes branch from 85d277f to 22e2afc Compare January 15, 2025 09:24
@rymnc rymnc enabled auto-merge (squash) January 15, 2025 11:07
@rymnc rymnc merged commit ab816ec into master Jan 15, 2025
90 checks passed
@rymnc rymnc deleted the proving/compressed-header-changes branch January 15, 2025 11:28
@MitchTurner MitchTurner mentioned this pull request Jan 22, 2025
MitchTurner added a commit that referenced this pull request Jan 22, 2025
## Version v0.41.1

* fault_proving(compression): include block_id in da compressed block
headers by @rymnc in #2551
* chore: Add myself and Andrea as codeowner for graphql API + related
crates by @netrome in #2570
* fix(integration_tests): remove flake from
produce_block__l1_committed_block_affects_gas_price by @rymnc in
#2566
* bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis
better by @MitchTurner in
#2599
* Fix version compatibility error by @AurelienFT in
#2608
* Improve error messages for responses from committer by @MitchTurner in
#2609
* Update async processor tests by @rafal-ch in
#2577
* The amount of returned dust coins is limited by factor relative to the
amount of selected big coins by @rafal-ch in
#2610
* fix(da_compression): invalid decompression of utxo id and CoinConfig
fix by @rymnc in #2593
* Use latest gas price to estimate next price for tx pool checks by
@MitchTurner in #2612
* Set Latest Recorded Height on startup by @MitchTurner in
#2603
* Use latest gas price to estimate next block gas price during dry runs
by @MitchTurner in #2615
* Check that fuel-core lib builds correctly without default features by
@rafal-ch in #2594
* Expose indexation status in `NodeInfo` endpoint by @rafal-ch in
#2595


**Full Changelog**:
v0.41.0...v0.41.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fault_proving(compression): add block_id to compressed block header
4 participants