Set Latest Recorded Height on startup

CHANGELOG.md

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Added
 - [2551](https://github.com/FuelLabs/fuel-core/pull/2551): Enhanced the DA compressed block header to include block id.
 
+### Changed
+- [2603](https://github.com/FuelLabs/fuel-core/pull/2603): Sets the latest recorded height on initialization, not just when DA costs are received
+
 ## [Version 0.41.0]
 
 ### Added

crates/services/gas_price_service/src/v1/tests.rs

@@ -237,9 +237,10 @@ impl GetLatestRecordedHeight for UnimplementedStorageTx {
 }
 
 impl AsUnrecordedBlocks for UnimplementedStorageTx {
-    type Wrapper<'a> = UnimplementedStorageTx
-        where
-            Self: 'a;
+    type Wrapper<'a>
+        = UnimplementedStorageTx
+    where
+        Self: 'a;
 
     fn as_unrecorded_blocks(&mut self) -> Self::Wrapper<'_> {
         UnimplementedStorageTx
@@ -973,3 +974,55 @@ async fn uninitialized_task__init__if_metadata_behind_l2_height_then_sync() {
 
     assert_eq!(on_chain_height, algo_updater_height);
 }
+
+#[tokio::test]
+async fn uninitialized_task__init__sets_latest_recorded_height_to_l2_height_if_none() {
+    // given
+    let metadata_height = 100;
+    let l2_height = 200;
+    let config = zero_threshold_arbitrary_config();
+
+    let metadata = V1Metadata {
+        new_scaled_exec_price: 100,
+        l2_block_height: metadata_height,
+        new_scaled_da_gas_price: 0,
+        gas_price_factor: NonZeroU64::new(100).unwrap(),
+        total_da_rewards: 0,
+        latest_known_total_da_cost: 0,
+        last_profit: 0,
+        second_to_last_profit: 0,
+        latest_da_cost_per_byte: 0,
+        unrecorded_block_bytes: 0,
+    };
+    let gas_price_db = gas_price_database_with_metadata(&metadata, None);
+    let mut onchain_db = FakeOnChainDb::new(l2_height);
+    for height in 1..=l2_height {
+        let block = arb_block();
+        onchain_db.blocks.insert(BlockHeight::from(height), block);
+    }
+
+    let service = UninitializedTask::new(
+        config,
+        Some(metadata_height.into()),
+        0.into(),
+        FakeSettings::default(),
+        empty_block_stream(),
+        gas_price_db,
+        FakeDABlockCost::never_returns(),
+        onchain_db.clone(),
+    )
+    .unwrap();
+
+    // when
+    let gas_price_service = service.init(&StateWatcher::started()).await.unwrap();
+
+    // then
+    // sleep to allow the service to sync
+    tokio::time::sleep(std::time::Duration::from_millis(100)).await;
+
+    let recorded_height = gas_price_service
+        .storage_tx_provider()
+        .get_recorded_height()
+        .unwrap();
+    assert_eq!(recorded_height, Some(l2_height.into()));
+}

crates/services/gas_price_service/src/v1/uninitialized_task.rs

@@ -198,10 +198,15 @@ where
             self.block_stream,
         );
 
-        let starting_recorded_height = self
-            .gas_price_db
-            .get_recorded_height()?
-            .unwrap_or(BlockHeight::from(latest_block_height));
+        let starting_recorded_height = match self.gas_price_db.get_recorded_height()? {
+            Some(height) => height,
+            None => {
+                let mut storage_tx = self.gas_price_db.begin_transaction()?;
+                storage_tx.set_recorded_height(BlockHeight::from(latest_block_height))?;
+                AtomicStorage::commit_transaction(storage_tx)?;
+                BlockHeight::from(latest_block_height)
+            }
+        };
 
         let poll_duration = self.config.da_poll_interval;
         let latest_l2_height = Arc::new(AtomicU32::new(latest_block_height));