refactor: improve how we build classNames #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helciofranco
requested review from
luizstacio,
pedronauck and
LuizAsFight
as code owners
pedronauck
suggested changes
Feb 26, 2024
pedronauck
suggested changes
Feb 26, 2024
pedronauck
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been running
twMergeandclsxon every re-render, it led to some kind of performance issue.So this PR is replacing
twMergewith a simpleclsxand also running it ONLY when it is really necessary.With these changes, we can get a great performance on rendering.
Reference: prefer twJoin over twMerge