This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
enhancement: transparently add internal types for GraphQL connection specification #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekerno
force-pushed
the
deekerno/add-transparent-pagination-types-to-schema
branch
from
82ddb1b to
283a200
Compare
deekerno
changed the title
deekerno
changed the title
deekerno
force-pushed
the
deekerno/add-transparent-pagination-types-to-schema
branch
7 times, most recently
from
e46e4ee to
f0c6d56
Compare
deekerno
force-pushed
the
deekerno/add-transparent-pagination-types-to-schema
branch
from
f0c6d56 to
c2fbd80
Compare
deekerno
changed the title
lostman
previously approved these changes
Oct 17, 2023
deekerno
force-pushed
the
deekerno/add-transparent-pagination-types-to-schema
branch
from
5ddcaae to
bacecbc
Compare
lostman
approved these changes
Oct 17, 2023
ra0x3
approved these changes
Oct 17, 2023
deekerno
deleted the
deekerno/add-transparent-pagination-types-to-schema
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR transparently adds internal types to be used as part of the GraphQL connections specification. A user will not have to add these types to their schema as they will be generated and added to their schema for each field that uses a list type. The next PR will add functionality for creating introspection information, which will expose these types to clients.
Testing steps
Added new unit tests. CI should pass.
Manual Testing
Run the fuel-explorer example and ensure that it works properly.