Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Adding Helm Chart for infra-v2 #1419

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Adding Helm Chart for infra-v2 #1419

merged 1 commit into from
Oct 25, 2023

Conversation

liviudm
Copy link
Contributor

@liviudm liviudm commented Oct 18, 2023

closes https://github.com/FuelLabs/fuel-deployment-v2/issues/20

Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.

Checklist

  • Ensure your top-level commit message is in line with our contributor guidelines.
  • Please add proper labels.
  • If there is an issue associated with this PR, please link the issue (right-hand sidebar)
  • If there is not an issue associated with this PR, add this PR to the "Fuel Indexer" project (right-hand sidebar)
  • Please allow Codeowners at least 24 hours to do a first-pass review.
  • Please add thoroughly detailed testing steps below.
  • Please keep your Changelog message short and sweet.

Description

Please include a short description of what this PR does.

Testing steps

Please provide the exact testing steps for the reviewer(s) if this PR requires testing.

Changelog

Please add neat Changelog info here, according to our Contributor's Guide.

@liviudm liviudm requested a review from Voxelot October 18, 2023 08:47
@liviudm liviudm self-assigned this Oct 18, 2023
@ra0x3
Copy link
Contributor

ra0x3 commented Oct 18, 2023

@liviudm

  • Do we anticipate that there will be any changes to how we deploy in dev after this PR is merged?
  • The changes look fine with me, just not sure what the effect of this will be for us

@liviudm
Copy link
Contributor Author

liviudm commented Oct 24, 2023

@ra0x3 the current dev environment is not affected. I didn't touch the current configuration. This applies only for the new infrastructure setup, where we deploy via Flux, as we discussed in our meeting last week.

Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liviudm

@ra0x3 ra0x3 merged commit 4108d15 into develop Oct 25, 2023
@ra0x3 ra0x3 deleted the feat/add-helm-chart branch October 25, 2023 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants