Skip to content
This repository has been archived by the owner on May 11, 2023. It is now read-only.

cargo clippy lints #103

Merged
merged 3 commits into from
Jun 20, 2022
Merged

cargo clippy lints #103

merged 3 commits into from
Jun 20, 2022

Conversation

rakita
Copy link
Contributor

@rakita rakita commented Jun 20, 2022 •
edited
Loading

Resolving cargo clippy lints.

Added two exceptions used only in tests:

  • clippy::bool_assert_compariso for assert_eq!(Position(0).is_leaf(), true);
  • clippy::identity_op for FEE * 1 as it gives better clarity to have that number.

and we probably need to add clippy to ci: #102

@rakita rakita requested review from Voxelot, adlerjohn and bvrooman June 20, 2022 08:24
@rakita rakita self-assigned this Jun 20, 2022
bvrooman
bvrooman previously approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@bvrooman bvrooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

adlerjohn
adlerjohn reviewed Jun 20, 2022
View reviewed changes
src/sparse/node.rs Outdated Show resolved Hide resolved
src/sparse/node.rs Outdated Show resolved Hide resolved
@rakita rakita enabled auto-merge (squash) June 20, 2022 18:10
@rakita rakita requested review from adlerjohn and bvrooman June 20, 2022 18:10
@rakita rakita merged commit 29e300e into master Jun 20, 2022
@rakita rakita deleted the rakita/clippy branch June 20, 2022 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Voxelot Voxelot Awaiting requested review from Voxelot

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@bvrooman bvrooman Awaiting requested review from bvrooman

Assignees

@rakita rakita

Labels
None yet
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakita @adlerjohn @bvrooman