This repository has been archived by the owner on May 11, 2023. It is now read-only.
Revert #115 #116
Merged
Revert #115 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf20199.
bvrooman
changed the title
ghost
approved these changes
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #115, commit bf20199.
It turns out that removing the first leaf from the BMT proof set makes it incompatible with the current implementation of proof verification in
test-helpers/src/binary/verify.rs. Proof sets without the first leaf (the leaf being proven) are incomplete; the first leaf is required in order to allow the proof set to be properly hashed together to form the root signature.The previous PR removed the first leaf from the public implementation of the proof sets. However, the reference implementation began to fail its verification test suite once I updated it to remove the first leaf from its proof sets. Therefore, I am reverting the change to remove the first leaf from the public implementation in order to maintain parity with the reference implementation.