Use self instead of &self during decompression
#824
Conversation
There was a problem hiding this comment.
Looks correct to me. However, it is not obvious to me what the benefit of doing this are. What do we gain by taking ownership/moving the compressed value as opposed to reading it over a reference?
The only obvious improvement I can see is for PoliciesBits where we skip a redundant dereferencing operation, but for UtxoId and impl_substitutable_key we need to create new references within the functions instead.
…move-value-during-decompression
|
It has more sense in the case of messages and coins(predicate data for example, where we just move vector instead of cloning it). |
Alright, makes sense. Thanks for clarifying! |
xgreenx
dismissed stale reviews from rafal-ch, netrome, and Dentosal
The base branch was changed.
…pression # Conflicts: # CHANGELOG.md # fuel-tx/src/transaction/policies.rs
Just move
selfduring deserialization since in most cases we will do nothing with it.