Bugfix: more receipt generation issues with debugger #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
requested review from
xgreenx,
MitchTurner and
Voxelot
as code owners
xgreenx
reviewed
Feb 7, 2025
| @@ -1042,16 +1044,11 @@ where | |||
| &self.balances, | |||
| gas_price, | |||
| )?; | |||
| self.update_transaction_outputs()?; | |||
| *self.tx.as_script_mut().unwrap().receipts_root_mut() = self.receipts.root(); | |||
There was a problem hiding this comment.
Whiel it is true that we run only script, I still prefer to sue if let Some(script)=)
There was a problem hiding this comment.
At the top of the function we error if as_script() cannot be used. We only access it again like this to satisfy borrow checker.
There was a problem hiding this comment.
Then would be nice to have expect and the comment that point to the top=D
There was a problem hiding this comment.
I agree. I don't think we should unwrap anywhere in our prod code. I prefer the type-safe approach too--expect is more acceptable than unwrap but it's fragile still.
xgreenx
approved these changes
Feb 10, 2025
netrome
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #889 fixed some receipt generation issues it missed regenerating receipts_root after the debugger is done. Also the in-memory outputs were updated too early.
Checklist
Before requesting review