docs: add essentials section for Transactions #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/docs/transactions-contracts
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
nedsalk and
petertonysmith94
as code owners
nedsalk
reviewed
Mar 28, 2024
nedsalk
reviewed
Mar 28, 2024
apps/docs-snippets/src/guide/transactions/transaction-response.test.ts
Outdated
Show resolved
Hide resolved
nedsalk
reviewed
Mar 28, 2024
nedsalk
reviewed
Mar 28, 2024
nedsalk
reviewed
Mar 28, 2024
nedsalk
reviewed
Mar 28, 2024
nedsalk
reviewed
Mar 28, 2024
nedsalk
reviewed
Mar 28, 2024
There was a problem hiding this comment.
- For me, whitespace between the comments on the docs-snippets, would be easier on the eyes. Feels crowded to me - see here.
- Also, it appears that types aren't being imported correctly in the final render.
I would favour omitting types from docs-snippets, so then they can be leveraged by both JavaScript and TypeScript developers, what are your thoughts?
apps/docs-snippets/src/guide/transactions/transaction-parameters.test.ts
Show resolved
Hide resolved
Co-authored-by: Nedim Salkić <[email protected]>
Co-authored-by: Nedim Salkić <[email protected]>
Co-authored-by: Nedim Salkić <[email protected]>
Co-authored-by: Nedim Salkić <[email protected]>
danielbate
dismissed stale reviews from Torres-ssf and petertonysmith94
via
fd94e8f
…/docs/transactions-contracts
Dhaiwat10
reviewed
Apr 10, 2024
apps/docs-snippets/src/guide/transactions/transaction-parameters.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dhaiwat <[email protected]>
…/docs/transactions-contracts
Dhaiwat10
approved these changes
Apr 14, 2024
petertonysmith94
approved these changes
Apr 15, 2024
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1923
This PR introduces a section to the essentials docs around Transactions. It includes pages on the following: