-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: assembly process for account transfer operation #2963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this @Torres-ssf , LGTM I've just left a comment re: release notes.
I've tested this out on fuel-wallet and verified the fix as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Torres-ssf,
I added a PR with two tests - one of which didn't have the results I was expected. If you could assist my understand, I'd be grateful.
Coverage Report:
Changed Files:
|
Summary
This PR improves the logic for assembling account transfer operations by extracting the sender's address directly from the transaction inputs (Coins and Messages) instead of relying on the
OutputChange
. This update ensures the sender's identification is more accurate in account transfer operations.Breaking Changes
The
getTransferOperations
helper function now requires an additional baseAssetId parameter.Checklist