Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use configurable offset for blob ID #3631

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Jan 28, 2025

Release notes

In this release, we:

  • Updated how we calculate Blob ID so that it mirrors Bytecode ID

Summary

Now uses the configurable offset to calculate the blob ID, so that it mirrors bytecode ID. This is to support verifiable ABIs.

We have a good range of tests in this area, all of which are passing before and after the change.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the feat Issue is a feature label Jan 28, 2025
@danielbate danielbate self-assigned this Jan 28, 2025
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:33am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:33am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:33am

@danielbate danielbate changed the title feat: use configurable offset for blob uploads feat: use configurable offset for blob ID Jan 28, 2025
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.07%(+0.03%) 70.68%(+0.04%) 75.14%(+0.04%) 77.07%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.46%
(-0.09%)
59%
(+0.54%)
69.89%
(+0%)
68.2%
(-0.08%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)
🔴 packages/address/src/address.ts 90.69%
(-0.21%)
92.85%
(+6.19%)
85.71%
(+0%)
90.9%
(-0.17%)
🔴 packages/address/src/utils.ts 80.95%
(+11.72%)
68.75%
(+18.75%)
83.33%
(+5.56%)
81.39%
(+11.02%)

@danielbate danielbate merged commit ec84b8a into master Jan 28, 2025
29 checks passed
@danielbate danielbate deleted the db/feat/use-bytecode-id-for-blob-uploads branch January 28, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use configurable offset instead of data offset for blob ID
4 participants