Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use GitHub vars instead of env vars #3649

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mchristopher
Copy link
Member

@mchristopher mchristopher commented Jan 30, 2025

Summary

This PR updates the values in the GitHub release workflow to source values from GitHub variables and not environment variables.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 6:36pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 6:36pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 6:36pm

@github-actions github-actions bot added the bug Issue is a bug label Jan 30, 2025
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.09%(+0.05%) 70.74%(+0.1%) 75.17%(+0.07%) 77.08%(+0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
✨ packages/account/src/assets/assets.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)
✨ packages/account/src/assets/utils/fuelAssetsBaseUrl.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)
🔴 ✨ packages/account/src/assets/utils/network.ts 91.3%
(+91.3%)
83.33%
(+83.33%)
100%
(+100%)
91.3%
(+91.3%)
✨ packages/account/src/assets/utils/resolveIconPaths.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)
🔴 ✨ packages/account/src/assets/utils/url.ts 100%
(+100%)
88.88%
(+88.88%)
100%
(+100%)
100%
(+100%)
🔴 packages/account/src/providers/provider.ts 68.52%
(-0.03%)
58.91%
(+0.45%)
70.21%
(+0.32%)
68.26%
(-0.02%)
🔴 packages/account/src/providers/generated/operations.ts 94.11%
(+0.08%)
100%
(+0%)
82%
(+0.37%)
94.57%
(+0.06%)
🔴 packages/address/src/address.ts 90.69%
(-0.21%)
92.85%
(+6.19%)
85.71%
(+0%)
90.9%
(-0.17%)
🔴 packages/address/src/utils.ts 80.95%
(+11.72%)
68.75%
(+18.75%)
83.33%
(+5.56%)
81.39%
(+11.02%)
🔴 packages/math/src/bn.ts 89.81%
(+0.19%)
87.5%
(+0.66%)
83.33%
(+0%)
89.81%
(+0.19%)

@arboleya arboleya merged commit 06e70dc into master Jan 30, 2025
34 of 36 checks passed
@arboleya arboleya deleted the mchristopher/fix/correct-aws-var-names branch January 30, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants