Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove pageInfo from getBalances GraphQl operations #3652

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Jan 31, 2025

Release notes

In this release, we:

  • Removed pageInfo from provider.operations.getBalances response

Summary

Breaking Changes

The pageInfo field has been removed from the response of the provider.operations.getBalances query.

// before
const { balances, pageInfo } = await provider.operations.getBalances({
  first: 100,
  filter: { owner: wallet.address.toB256() },
});
// after
const { balances } = await provider.operations.getBalances({
  first: 100,
  filter: { owner: wallet.address.toB256() },
});

The getBalances method of the Provider class remains unchanged, as it never returned pageInfo:

// not affected
const { balances } = await provider.getBalances();

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:12am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:12am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:12am

@github-actions github-actions bot added the chore Issue is a chore label Jan 31, 2025
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.07%(+0%) 70.72%(+0%) 75.17%(+0%) 77.07%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit 4428556 into master Jan 31, 2025
28 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/remove-page-info-from-get-balances branch January 31, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pageInfo from getBalances GraphQL operation
3 participants