Update forc-crypto to use latest libraries #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr-fuel
force-pushed
the
forc-crypto-update
branch
2 times, most recently
from
c41cc7d to
1efa5ac
Compare
Voxelot
approved these changes
Nov 13, 2023
Merged
IGI-111
force-pushed
the
upgrade/fuel-core-master
branch
from
0244530 to
4caa569
Compare
cr-fuel
force-pushed
the
forc-crypto-update
branch
5 times, most recently
from
370fdb3 to
dd50952
Compare
cr-fuel
force-pushed
the
forc-crypto-update
branch
from
dd50952 to
c398954
Compare
JoshuaBatty
approved these changes
Nov 17, 2023
cr-fuel
added a commit
that referenced
this pull request
Nov 20, 2023
Update `fuel-core` and use the `fuel-core-keygen` crate instead of duplicating code between `forc-crypto` and `fuel-core` - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
cr-fuel
added a commit
that referenced
this pull request
Nov 20, 2023
Update `fuel-core` and use the `fuel-core-keygen` crate instead of duplicating code between `forc-crypto` and `fuel-core` - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
fuel-coreand use thefuel-core-keygencrate instead of duplicating code betweenforc-cryptoandfuel-coreChecklist
Breaking*orNew Featurelabels where relevant.