Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4.2 Bump Friendly id to v5.1.0 #28

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

glongman
Copy link

No description provided.

@glongman glongman requested a review from kurtfunai July 31, 2017 14:46
@kurtfunai
Copy link

Slightly worried about a change in this version bump:
https://github.com/norman/friendly_id/blob/master/Changelog.md
That said, it is required for 4.2 - so not really a choice.

My concern only stems from the fact our TP's do have some empty slug values (but if that TP is touched again it generates a slug for it - so maybe we are in the clear)

@glongman
Copy link
Author

glongman commented Jul 31, 2017 via email

@glongman glongman changed the title Rails 4.2 Bump Friendly id to v5.1.0 WIP Rails 4.2 Bump Friendly id to v5.1.0 Jul 31, 2017
@glongman glongman changed the title WIP Rails 4.2 Bump Friendly id to v5.1.0 Rails 4.2 Bump Friendly id to v5.1.0 Jul 31, 2017
@glongman glongman merged commit d37933d into 2-2-stable-healthwave Jul 31, 2017
@glongman glongman deleted the friendly_id-v-5.1.0 branch July 31, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants