Persist attributes before save #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bliof
suggested changes
Oct 2, 2018
finalwharf
force-pushed
the
master
branch
2 times, most recently
from
b816bff to
54b6047
Compare
finalwharf
force-pushed
the
persist_before_save
branch
from
3889fa1 to
8fc83e2
Compare
Persisting Vault attributes on an `after_save` uses two separate queries: one for the model `INSERT/UPDATE`, and another to `UPDATE` the ciphertext for the encrypted attributes. Encrypting the attributes with a `before_save` avoids the second query. In some cases users might _not_ want to have two queries when saving a single record. This would be necessary for example, when one has an auditing table and/or stored procedures that take some action when a record is changed.
finalwharf
force-pushed
the
persist_before_save
branch
from
8fc83e2 to
ba2de1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
lib/vault/encrypted_model.rbAny background context you want to provide?
after_saveuses two separate queries:one for the model
INSERT/UPDATE, and another toUPDATEthe ciphertextfor the encrypted attributes. Encrypting the attributes with a
before_saveavoids the second query. In some cases users might not want to have two
queries when saving a single record. This would be necessary for example,
when one has an auditing table and/or stored procedures that take some action
when a record is changed.
/cc @popovm