Add model level batch api to 0.7 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.vault_persist_all and .vault_load_all are methods, that can be used for batch operations of several records. .vault_load_all is useful only when in combination with lazy decryption. Note that although this commit is forwardported from the 0.6 version we've updated the implementation to work with the rails 5 attribute API we use in 0.7.
For both encryption and decryption we need the same initialization phase of reading the configuration options. The idea is to avoid code repetition and cluttering even more code in EncryptedModel. Note that although this commit is forwardported from the 0.6 version we've updated the implementation to work with the rails 5 attribute API we use in 0.7.
popovm
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively this is a rewrite of #41 for the 0.7 version of the gem. I mistakenly thought that we already had the model level batch stuff in 0.7 because we had the
Vault::Rails.batch_encryptandVault::Rails.batch_decryptmethods which were added in #22. We don't take all the commits from #41 though because I already took one of them over to 0.7 in #50, which should have been a hint that I was missing the rest of it TBH. 😞