Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serializers for Dates, Integers and Floats #6

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add serializers for Dates, Integers and Floats #6

merged 1 commit into from
Oct 8, 2018

Conversation

finalwharf
Copy link

What does this PR do?

  • Add serializers for Dates, Integers and Floats

Where should the reviewer start?

  • lib/vault/rails/serializers/

Any background context you want to provide?

  • Vault assumes every value we store is a string. The only available serializer is a JSON serializer, which is not enough.

/cc @popovm please review

@finalwharf finalwharf requested a review from popovm October 5, 2018 08:26
popovm
popovm approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@popovm popovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@finalwharf finalwharf merged commit 74002dc into master Oct 8, 2018
@finalwharf finalwharf deleted the serializers branch October 8, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popovm popovm popovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finalwharf @popovm