Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #8

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Update README.md #8

merged 1 commit into from
Oct 9, 2018

Conversation

finalwharf
Copy link

@finalwharf finalwharf commented Oct 9, 2018

Reflect the improvements made so far in README.md

@finalwharf finalwharf requested a review from popovm October 9, 2018 10:22
@popovm
Copy link
Member

popovm commented Oct 9, 2018

Good job! @finalwharf
Do we want to add a section with a few words about lazy decryption too? 💭

README.md Outdated
@@ -117,6 +117,12 @@ vault_attribute :details
serialize: :json
```

This is the list of included serializer:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serializers 🔬

README.md Outdated
@@ -202,6 +214,27 @@ So for the example above, the key would be:
my_app_people_ssn


### Convergent Encryption
Convergent encryption is a mode where the same set of plaintext and context always result in the same ciphertext. It does this by deriving a key using a key derivation function but also by deterministically deriving a nonce. You can use this if you need to check for uniquenesson you attributes, of if you need to have the ability to do a search (exact-match).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uniqueness on ... or if you need 🔬

README.md Outdated
### Convergent Encryption
Convergent encryption is a mode where the same set of plaintext and context always result in the same ciphertext. It does this by deriving a key using a key derivation function but also by deterministically deriving a nonce. You can use this if you need to check for uniquenesson you attributes, of if you need to have the ability to do a search (exact-match).

Vault supports convergent encryptions since v0.6.1. We take advantege of this functionality.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encryption should be singular.
Small typo in advantage.

@finalwharf finalwharf force-pushed the update_readme branch 3 times, most recently from d18f600 to d858666 Compare October 9, 2018 10:59
@finalwharf finalwharf merged commit 85f19d3 into master Oct 9, 2018
@finalwharf finalwharf deleted the update_readme branch October 9, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants