Fix crashes when there isn't a database #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bliof
force-pushed
the
fix-rails-db-create
branch
from
7f95f8b to
b7104a8
Compare
bliof-fc
force-pushed
the
fix-rails-db-create
branch
7 times, most recently
from
f746a0f to
7a05777
Compare
When running db:create or assets:precompile the gem does a db connection for no reason in rails 5.x. In rails 4 it is not doing it. The bug happens here: https://github.com/rails/rails/blob/v5.2.6/activerecord/lib/active_record/type.rb#L41 ``` def lookup(*args, adapter: current_adapter_name, **kwargs) # :nodoc: ``` `current_adapter_name` for some reason does a db connection.
The lookup call tries to establish connection to the database when the application code is loading. This bugs rake tasks like db:create / assets:precompile https://github.com/rails/rails/blob/v5.2.6/activerecord/lib/active_record/type.rb#L41 ``` def lookup(*args, adapter: current_adapter_name, **kwargs) # :nodoc: ``` The `current_adapter_name` for some reason does a db connection. The code is change to getting the current adapter with `ActiveRecord::Base.connection_config[:adapter]`, which is not making a db connection.
bliof-fc
force-pushed
the
fix-rails-db-create
branch
from
e054bdb to
006f61c
Compare
popovm
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lookupcall tries to establish connection to the database when the application code is loading.This bugs rake tasks like
db:create/assets:precompiledef lookup(*args, adapter: current_adapter_name, **kwargs) # :nodoc:The
current_adapter_namefor some reason does a db connection.The code is change to getting the current adapter with
ActiveRecord::Base.connection_config[:adapter], which is not making a db connection.Replace
update_attributeswithupdateas update_attributes has been removed in rails 6