[BO-1336] Update with official gem to 4.8.0 (into legacy-for-pro) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I scratched my head a bit on this one. I could only find my answer here https://github.com/collectiveidea/audited/blob/cd7065ef6fb9640a3a4e204477dd38dc0d12e50c/lib/audited/adapters/active_record/audit.rb#L40
Add missing `ruby` mark on README.md
2.0 is EOL so we aren't going to explicitly test it anymore.
This was causing issues with MySQL in tests.
Fix broken MySQL tests
The on_start values changed.
Do not connect to db until needed fix collectiveidea#239
Similar to pull collectiveidea#185, this pull should eliminate the deprecation warnings RSpec emits when using the audited RSpec matchers. Aliasing the methods should leave it compatible with earlier versions of RSpec as well.
…r_compatibility Alias RSpec matcher methods for RSpec 3
…-20-tests Remove Ruby 2.0 from Travis builds
Fixed README to avoid conflicts in rails 5.
For compatibility with, e.g., sidekiq
It is defined in the gemspec.
Deprecate Audited.audit_class since it was in the README for years, but remove the setter completely. This was needed when we had both ActiveRecord and MongoMapper versions, but is not longer needed.
Prepare for 4.7.0 release
Backport 5.2 support to 4.7 stable
(cherry picked from commit c48893a)
(cherry picked from commit dc72762)
(cherry picked from commit 8486dec)
(cherry picked from commit fd95166)
(cherry picked from commit ed4e2ec)
(cherry picked from commit 3b76fca)
(cherry picked from commit 46e560d)
(cherry picked from commit 02d2e24)
(cherry picked from commit ea58b01)
(cherry picked from commit 9cff81b)
(cherry picked from commit 250cacc)
* rename instance attribute version to audit_version seems dangerous to dynamically add an accessor method called version because version is such a common name and could lead to some unexpected behaviour in applications using audited. * Deprecate version attribute to prepare for removal * Update CHANGELOG * Implement deprecation only if version not in use in audited resource * Add version deprecation to uncovered * Update SingleCov uncovered count (cherry picked from commit 0296845)
Prepare 4.8.0 release
…hotfix/BO-1336/update-with-4-8-0 Version 4.8.0
patrickptasinskift
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fundthrough.atlassian.net/browse/BO-1336